search

novifinancial / serde-reflection

Rust libraries and tools to help with interoperability and testing of serialization formats based on Serde.
Apache License 2.0
139 stars 42 forks source link

quote var names to eliminate javascript keywords #94

Closed danprinz closed 3 years ago

danprinz commented 3 years ago

Summary

In the latest code generation, a variable name called function was used. While you can use it in other languages, JavaScript forbids the use of keywords as variable names.

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

facebook-github-bot commented 3 years ago

Hi @danprinz!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

ma2bd commented 3 years ago

@danprinz Thanks for the fix. Would you be able to sign the CLA again?

ma2bd commented 3 years ago

I'm going to pause this idea for now. We're considering renaming things on the user side instead at the moment.