search

novitai / skycompress

Compress the image with binary search algorithm to find best fit dimension and quality
1 stars 0 forks source link

What is bin file type???? #7

Closed sarpulas closed 10 months ago

sarpulas commented 10 months ago

It's all binary fam https://novit-ai.slack.com/archives/CC4G11QDN/p1696490473236659?thread_ts=1696489187.491539&cid=CC4G11QDN

furkan-novit commented 10 months ago

I say we remove bin and gry.

@sarpulas we have not needed those ever.

https://github.com/novitai/ultra-secret-project/blob/1f18b6e277e34acdcd8c149c57d70a7003497c12/legacy/image_compressor.py#L14

Gozgur commented 10 months ago

checked but couldn't find any useful information. and we do not use both of them bin and grey in the code. it is wrong or something

furkan-novit commented 10 months ago

Have we tried the script on grayscale images, by inspecting output images?

furkan-novit commented 10 months ago

We have now, but the code is a bit coupled. @Gozgur can you open an issue to get rid of bin and remove the repetition among gry and rgb?

Gozgur commented 10 months ago

https://en.wikipedia.org/wiki/Binary_image

What is a binary color? noun. : a color made by mixing two primary colors : secondary color.

sarpulas commented 10 months ago

OH okay so grayscale is black->white with every shade in gray in between Binary is ONLY black or white

Screenshot 2023-10-16 at 15 08 27

image

power of googling your question