search

novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj
Apache License 2.0
0 stars 0 forks source link

Bad position of printing wallet balance in Wallet.receive() #372

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is on bitcoinj 0.7.3.

The log.info("Balance is now...") in Wallet.receive() is printed too early for 
transactions that are received in blocks (e.g. during a replay) to be 
calculated correctly. Currently it always seems to print the previous balance 
in these cases.

Changing the BalanceType to ESTIMATED appears to fix it, but still the 
positioning of this log.info should get a second thought. Why not print it at 
the end of the method? Appears to be safest to me.

Original issue reported on code.google.com by andreas....@gmail.com on 27 Mar 2013 at 1:29

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision d64f55589694.

Original comment by hearn@google.com on 1 Apr 2013 at 5:14