exceptions in onCoinsReceived can result in loss of transaction(s)

[GoogleCodeExporter]

If an exception is thrown in a WalletEventListener.onCoinsReceived, 
transaction(s) go missing. I cannot currently tell its exactly the exceptions 
that are received with the listener.

If its of any use, I try to set up a testcase with wallet-tool.

Original issue reported on code.google.com by andreas....@gmail.com on 14 Apr 2013 at 9:04

[GoogleCodeExporter]

Another aspect of this: Will all other registered WalletEventListeners still be 
called? I would expect yes, especially since bitcoinj internally uses event 
listeners to keep consistency.

Original comment by andreas....@gmail.com on 15 Apr 2013 at 11:11

[GoogleCodeExporter]

One event listener throwing will prevent the rest from executing. You're right, 
we need to do a thorough scrub for exception safety. It isn't worth trying to 
fix this properly until the transaction confidence listeners are changed to run 
at the end of all operations, because an exception thrown from them could cause 
arbitrary corruption right now.

Original comment by hearn@google.com on 15 Apr 2013 at 11:16

• Changed state: Accepted

[GoogleCodeExporter]

You said this will be fixed with the latest changes on event-thread, will it?

Original comment by andreas....@gmail.com on 2 Jul 2013 at 7:39

[GoogleCodeExporter]

It should do yes, unless you override the default executor with 
Threading.SAME_THREAD (don't do that).

Original comment by hearn@google.com on 2 Jul 2013 at 7:59

[GoogleCodeExporter]

Original comment by hearn@google.com on 11 Jul 2013 at 1:00

• Changed state: Fixed