Loggers should always be static

[GoogleCodeExporter]

If you search for "public Logger log" - also in the testcase - you'll find some 
instance scoped loggers. Also, they don't take advantage of the Classname.class 
syntax in the .getLogger() parameter.

Original issue reported on code.google.com by andreas....@gmail.com on 3 Jul 2013 at 8:44

[GoogleCodeExporter]

Ah, and also loggers should not be public (KeyCrypterScrypt).

Original comment by andreas....@gmail.com on 3 Jul 2013 at 8:45

[GoogleCodeExporter]

The typical declaration is 

private static final Logger log = LoggerFactory.getLogger(Example.class);

Original comment by g.rowe.f...@gmail.com on 3 Jul 2013 at 8:46

[GoogleCodeExporter]

Ah, and one more: Logging should actually be used. There are several cases of 
"System.out.println" in bitcoinj main.

Original comment by andreas....@gmail.com on 3 Jul 2013 at 9:28

[GoogleCodeExporter]

This issue was closed by revision 8a74b3da2c42.

Original comment by hearn@google.com on 10 Jul 2013 at 12:42

• Changed state: Fixed

[GoogleCodeExporter]

Sorry, to nitpick, but there is still a KeyCrypterScrypt.class*.getName()*

Original comment by andreas....@gmail.com on 10 Jul 2013 at 2:18

• Changed state: Accepted

[GoogleCodeExporter]

This issue was closed by revision 53dc5c2e6a7a.

Original comment by hearn@google.com on 10 Jul 2013 at 2:23

• Changed state: Fixed