search

novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj
Apache License 2.0
0 stars 0 forks source link

nLockTime issues #446

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Peter Todd pointed out some nLockTime transactions not appearing in this 
comment:

https://github.com/bitcoin/bitcoin/pull/2340#issuecomment-23238887

Original issue reported on code.google.com by andreas....@gmail.com on 26 Aug 2013 at 5:30

GoogleCodeExporter commented 9 years ago 
While investigating into the first example, I found out there is now a 
tx.isTimeLocked() method. I simply had been using nLockTime > 0 before. 
However, it looks as if this method does not account for the case where (all?) 
sequence numbers are at MAX_INT.

Original comment by andreas....@gmail.com on 26 Aug 2013 at 5:58

GoogleCodeExporter commented 9 years ago 
Ah, NO_SEQUENCE *is* "max int".

Original comment by andreas....@gmail.com on 26 Aug 2013 at 9:15

GoogleCodeExporter commented 9 years ago 
I believe I actually addressed this issue in the payment channels branch of 
Bitcoin wallet.

Original comment by BlueMatt...@gmail.com on 26 Aug 2013 at 2:38

GoogleCodeExporter commented 9 years ago 
I saw you added the tx.isTimeLocked() method to bitcoinj. Thanks for that. 
However, the app still used the old logic. I fixed it in cb6df045 earlier 
today. However, this fixes only the first case from the linked comment.

Original comment by andreas....@gmail.com on 26 Aug 2013 at 4:20

GoogleCodeExporter commented 9 years ago 
I think this should be resolved by edf37998ca6c.

Original comment by mh.in.en...@gmail.com on 11 Nov 2013 at 6:09