search

novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj
Apache License 2.0
0 stars 0 forks source link

Method names for BIP32 related code reference SHA256 even though they are using SHA512 #449

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
com.google.bitcoin.crypto.HDUtils.java is an example of this:

static HMac createHmacSha256Digest(byte[] key)

static byte[] hmacSha256(HMac hmacSha256, byte[] input)

...etc. all use HmacSha512 (as they should!) but the method names are very 
misleading. Other HD... classes suffer from the same problem.

Original issue reported on code.google.com by d...@yubico.com on 12 Sep 2013 at 1:44

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision d0be53f0a14a.

Original comment by hearn@google.com on 8 Oct 2013 at 9:53