Bloom Filter never changed

[GoogleCodeExporter]

In PeerGroup.java, in the method recalculateFastCatchupAndFilter.

I see this logic:

bloomFilter = filter;

boolean changed = !filter.equals(bloomFilter);

Since the bloomFilter pointer is getting set to filter, is it possible for 
!filter.equals(bloomFilter) to ever resolve to true?

Original issue reported on code.google.com by skaj...@gmail.com on 22 Feb 2014 at 5:27

[GoogleCodeExporter]

Oops, that does indeed look wrong. I think it's not caught by the tests because 
we don't have a test that checks the Bloom filter is resent to peers when a key 
is added. Really the filtering stuff is under-tested in general.

This should get fixed for 0.11.1

Original comment by mh.in.en...@gmail.com on 22 Feb 2014 at 12:30

• Changed state: Accepted
• Added labels: Type-Defect, Priority-High
• Removed labels: Type-Enhancement, Priority-Medium

[GoogleCodeExporter]

This issue was closed by revision b52faae01305.

Original comment by mh.in.en...@gmail.com on 23 Feb 2014 at 12:12

• Changed state: Fixed

[GoogleCodeExporter]

This issue was closed by revision e783895dd37c.

Original comment by andreas....@gmail.com on 23 Feb 2014 at 9:22