search

novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj
Apache License 2.0
0 stars 0 forks source link

Pull request: Constant time wallet operations #525

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I switched the keychain in Wallet to a HashMap (indexed by pubkey hashes). Now 
wallet operations should happen in constant time (a huge speedup in selecting 
outputs to spend).

The changes are committed in my cloned repo: 
https://code.google.com/r/mappum-bitcoinj

I don't work with Java too much, let me know if I did anything that is bad 
practice.

Original issue reported on code.google.com by mappum@gmail.com on 25 Feb 2014 at 12:02

GoogleCodeExporter commented 9 years ago 
Heya,

That's a good idea - actually I already made this change as part the HD wallets 
work on a branch, so I think I might wait until the HDW work is complete to 
avoid conflicts. Sorry for the duplicated work, I keep getting pulled away into 
other tasks so HDW makes slow progress sometimes.

I'll close this bug for now. If you think I should merge anyway, before HDW, 
please reopen and we can discuss it.

Original comment by mh.in.en...@gmail.com on 25 Feb 2014 at 9:41