novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj
Apache License 2.0
0 stars 0 forks source link

Atomic operation on wallet to change encryption #539

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
E.g. to change the password, currently you need to wallet.decrypt (weird name 
by the way -- should be named something like removeEncryption) then 
wallet.encrypt.

There is a slim chance that inbetween a key is created and persisted to disk in 
the unencrypted form.

Thus, I propose there should be an atomic operation to change encryption.

Original issue reported on code.google.com by andreas....@gmail.com on 16 Mar 2014 at 5:55

GoogleCodeExporter commented 9 years ago
Why is "decrypt" a weird name?

Once HD wallets lands, private keys aren't actually stored for encrypted 
wallets anymore. They're derived on the fly. So I don't think this situation 
will be possible. However, it would be good form to have an atomic operation 
for it indeed, so I'll still add one anyway.

Original comment by mh.in.en...@gmail.com on 16 Mar 2014 at 6:12

GoogleCodeExporter commented 9 years ago
Just to make myself clear, I'm talking about atomicity in terms of locking and 
wallet state.

Original comment by andreas....@gmail.com on 16 Mar 2014 at 6:12

GoogleCodeExporter commented 9 years ago
Yes, I understood.

Original comment by mh.in.en...@gmail.com on 16 Mar 2014 at 6:15

GoogleCodeExporter commented 9 years ago

Original comment by andreas....@gmail.com on 16 Dec 2014 at 3:33