ECDSASignature does not override equals

novitski / bitcoinj

Automatically exported from code.google.com/p/bitcoinj

Apache License 2.0

0 stars 0 forks source link

ECDSASignature does not override equals #544

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

This means that things like 
TransactionSignature.dummy().equals(TransactionSignature.dummy()) is false

Original issue reported on code.google.com by ximo.gua...@gmail.com on 6 Apr 2014 at 9:32

GoogleCodeExporter commented 9 years ago

This issue was closed by revision e372aa443076.

Original comment by mh.in.en...@gmail.com on 7 Apr 2014 at 4:42

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

The issue was closed but the problem persists as equals has not been overridden.
TransactionSignature.dummy().equals(TransactionSignature.dummy()) is still 
false.

Can be reopened?

Original comment by mehequed...@gmail.com on 2 Jun 2014 at 5:06

GoogleCodeExporter commented 9 years ago

Just checking on master... equals is implemented and your test yields true.
To me, it seems fixed.

Original comment by andreas....@gmail.com on 2 Jun 2014 at 5:44

GoogleCodeExporter commented 9 years ago

Sorry, I just thought this patch went into 0.11.1...

Original comment by mehequed...@gmail.com on 2 Jun 2014 at 6:00