search

novnc / noVNC

VNC client web application
https://novnc.com
Other
11.42k stars 2.27k forks source link

Propogate "--key-password" websockify option to launch.sh #1490

Open EgorDuplensky opened 3 years ago

EgorDuplensky commented 3 years ago

Is your feature request related to a problem? Please describe. Currently it is not possible to use encrypted cert key when running websockify via utils/launch.sh

Describe the solution you'd like Expose "--key-password" to utils/launch.sh

Describe alternatives you've considered N/A

Additional context I can prepare a PR if maintainers are OK with the proposal

CendioOssman commented 3 years ago

We propagate various other things, so I don't see why we can't add this as well.

EgorDuplensky commented 3 years ago

Btw, It seems that websockify in general is way ahead in terms of command arguments compared to launch.sh. I see some checks are performed for some options before passing to websockify. Maybe it is better to just forward the arguments that launch.sh is not aware about to websockify?

CendioOssman commented 3 years ago

Yeah, launch.sh was just really a quick hack to make it easier to test and develop noVNC. So soem rethinking is probably needed to avoid all that duplication. Please send us a suggestion as a PR if you have the time.