Open mightypenguin opened 12 years ago
So many possibilities, so little time. :-)
First NoVnc is awesome !
The file transfer feature would be very useful for me !
I am using NoVnc in a docker environment so either I have to add a service for file transfer or I implement this functionality, but the protocol link you provided is broken and I do not now much about this project.
Do you have some insight on how to do it so I can estimate if I can and have the time to write this feature ?
The protocol specification has been moved here to github now: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst
However it does not contain any specification for a file transfer extension. So someone would need to write that first. And also check what x11vnc implements in order to be compatible with that docker setup.
Thanks for the answer, It seems be a lot of work and I am a bit short on time.
However I found an easy workaround by integrating filebrowser with docker.
In case it can help someone, there is the solution I've come with :
/etc/nginx/sites-enabled/default
:location /files/ {
proxy_pass http://files/files/;
}
This image is not public (yet), so i call it my_version_of_ubuntu-desktop-lxde-vnc
.
docker-compose.yml
putting the two images together:version: '2'
services:
vnc:
hostname: vnc
image: my_version_of_ubuntu-desktop-lxde-vnc
environment:
USER: ${VNCUSER}
SSL_PORT: 443
PASSWORD: ${PASSWORD}
ports:
- "${HTTPS_PORT}:443"
volumes:
- home:/home
networks:
- default
files:
hostname: files
# Stuck to v1.10.0 see https://github.com/filebrowser/filebrowser/issues/534
image: filebrowser/filebrowser:v1.10.0
# Uncoment for debug purposes
# ports:
# - 6082:80
command: --no-auth --baseurl=/files
volumes:
- home:/srv
networks:
- default
volumes:
home:
networks:
default:
With that configuration https://localhost:6081/ brings me to the vnc and https://localhost:6081/files/ brings me to filebrowser from which I can upload and download files in /home
.
.env
:VNCUSER=test
PASSWORD=test
HTTPS_PORT=6081
When will this exciting feature go live?
For information, since my last message we've make a public repository with a docker-compose that binds together filebrowser and noVNC : https://gitlab.tetras-libre.fr/nocloud/docker/vnc
I would love this, and maybe even love to work on it myself. But... how to find out how it should behave, protocol-wise?
I've had a go at trying to work out what the protocol is for file uploads. What I have so far is at
I've found 3 competing protocols so far...
KasmVNC has a file upload/download functionality but the project mentions they have broken from the RFB spec: https://github.com/kasmtech/KasmVNC
edit: It might be the case that the file upload/download feature is part of Kasm workspaces and not KasmVNC.
Yeah, it would be nice if Kasm could give back to the projects they rely on, sadly they haven't contributed anything so far.
Here's a great idea for someone else to code up!
TightVNC style file transfer support in noVNC!
I think the protocol is defined here: http://tigervnc.com/cgi-bin/rfbproto