novnc / noVNC

VNC client web application
https://novnc.com
Other
11.15k stars 2.24k forks source link

Failed to start WebSockets proxy #1859

Open fabianhartmann2 opened 1 month ago

fabianhartmann2 commented 1 month ago

Describe the bug As soon as I use the --cert --key as arguments and the path to the cert contains spaces, I get the following error.

/Library/websockify/websockify/websocket.py:31: UserWarning: no 'numpy' module, HyBi protocol will be slower warnings.warn("no 'numpy' module, HyBi protocol will be slower") Usage: main.py [options] [source_addr:]source_port target_addr:target_port main.py [options] --token-plugin=CLASS [source_addr:]source_port main.py [options] --unix-target=FILE [source_addr:]source_port main.py [options] [source_addr:]source_port -- WRAP_COMMAND_LINE

main.py: error: Error parsing listen port

Failed to start WebSockets proxy

To Reproduce Steps to reproduce the behavior:

  1. Generate a self-signed cert and store it in a path with spaces.
  2. start novnc_proxy

Expected behavior websockify should launch and noVNC accessible.

Screenshots If applicable, add screenshots to help explain your problem.

Client (please complete the following information):

Server (please complete the following information):

Additional context Solution Changing line 195 of novnc_proxy to the following, solves the issue: ${WEBSOCKIFY} ${SYSLOG_ARG} ${SSLONLY} ${FILEONLY_ARG} --web "${WEB}" ${CERT:+--cert "${CERT}"} ${KEY:+--key "${KEY}"} ${PORT} ${VNC_DEST} ${HEARTBEAT_ARG} ${IDLETIMEOUT_ARG} ${RECORD_ARG} ${TIMEOUT_ARG} ${WEBAUTH_ARG} ${AUTHPLUGIN_ARG} ${AUTHSOURCE_ARG} &

CendioOssman commented 1 month ago

This should be fixed by #1741, but unfortunately that PR has stalled. :/