novnc / noVNC

VNC client web application
https://novnc.com
Other
11.48k stars 2.28k forks source link

Remove support for old Websocket protocols? #230

Closed astrand closed 11 years ago

astrand commented 11 years ago

The top of websocket.py claims that we support hixie-75, hixie-76, hybi-10. This comment seems to be stale; we support version 7 and 13 as well, ie RFC 6455. I'm wondering, does it really make sense to maintain support for all those obsolete versions? All desktop browsers supports the real RFC 6455 protocol now. The only possible problem might be old IOS devices, but are they important enough? hixie-76 broke compatibility with reverse-proxies and gateways, and hixie-75 is, as far as I understand, full of problems as well. If I create a patch that removes everything except support for RFC 6455, would you accept that?

kanaka commented 11 years ago

@astrand Yes. Now that iOS 6 has support for IETF 6455, I am okay with removing support from master (I'll branch a version that has the old code for a while in case people still need it).

Please keep the support for older HyBi versions for now since it's really just a couple of lines in do_websocket_handshake (the differences are minor anyways and don't affect the code other than the check). Also, it would probably be good to recognize the Hixie protocol in do_websocket_handshake and show an informative error.

kanaka commented 11 years ago

Move to websockify: https://github.com/kanaka/websockify/pull/70