search

novoda / bintray-release

A helper for releasing from gradle up to bintray
Other
1.86k stars 208 forks source link

Doesn't work with any newer version of the Gradle Plugin and/or Gradle #63

Closed afollestad closed 9 years ago

afollestad commented 9 years ago

This library hasn't worked for months now, I get a warning that's worded something like "cannot access first() from list".

blundell commented 9 years ago

Can you give us an example project for which it does not work? Works fine on all our proj's

afollestad commented 9 years ago

https://github.com/afollestad/bridge and https://github.com/afollestad/material-dialogs are both examples.

screen shot 2015-07-17 at 1 07 04 pm
afollestad commented 9 years ago

The problem goes away if you remove bintray-release, which I did; I'm guessing it's an incompatibility issue with the next version (currently in beta) of Gradle and/or the Gradle plugins.

afollestad commented 9 years ago

Looks like this is the same as https://github.com/novoda/bintray-release/issues/56, although I'm using Gradle 2.5. @blundell

ouchadam commented 9 years ago

cc @Dorvaryn I believe this is the same issue we saw in https://github.com/novoda/rxpresso when it was an inner module

afollestad commented 9 years ago

Build Tools 23.0.0, SDK v23 (Marshmallow), Gradle Plugin 1.3.0, and Google libs (AppCompat, etc.) 23.0.0 are all available now.

This library still does not work.

ZacSweers commented 9 years ago

The problem is pretty simple. As they're preparing for Jack and Jill, the compilation tasks are getting moved around. The problem is here:

https://github.com/novoda/bintray-release/blob/master/core%2Fsrc%2Fmain%2Fgroovy%2Fcom%2Fnovoda%2Fgradle%2Frelease%2FAndroidLibrary.groovy#L17-L18

The variants haven't been resolved at that point. Maybe you should postpone it until after evaluation.

This is a great example of why you should have tests. The library is 3 versions of gradle behind, several versions of the bintray plugin behind, and doesn't even depend on the Android Gradle Plugin despite relying on its configurations to exist. Seems like it's fallen into disrepair and could use some love.

ZacSweers commented 9 years ago

Opened a pull request in https://github.com/novoda/bintray-release/pull/66. Please take a look when possible.