novoda / download-manager

A library that handles long-running downloads, handling the network interactions and retrying downloads automatically after failures
Apache License 2.0
483 stars 63 forks source link

Feature Request: Ability to override allowed connection type. #455

Open Hackmodford opened 6 years ago

Hackmodford commented 6 years ago

Is it possible to let some batches download under any condition despite allowed network type? Sometimes when starting the downloads, I let the users specify if they would like to download the large files over cellular instead of wifi.

Mecharyry commented 6 years ago

Hi @Hackmodford, sorry for the delay in getting back to you.

This would probably be quite a large change as it would require us to persist this network preference for per batch. I'll chat with the other devs and we'll see if we can plan it in. This would probably have to ship with a major/minor release of the library, so it won't be a quick turnaround unfortunately.

Mecharyry commented 5 years ago

@danybony @zegnus what do you think about this, should we allow greater flexibility when it comes to network connections?

zegnus commented 5 years ago

@Mecharyry this requires a careful look into the recovery mechanism as well, I'll try to evaluate its complexity this week

Mecharyry commented 5 years ago

Just wanted to say that this is probably closely matching what we do for the StorageRequirementRule in terms of functionality.