Closed Mecharyry closed 5 years ago
Local builds are passing when PRs opened are being failed by the CI, this is because we set a local threshold for local builds but not for PRs. When reducing the number of warnings / errors in the project we should change this threshold accordingly.
Change the threshold for local builds now that there aren't any errors in the build. Use the latest version of Merlin to prevent a failure. https://github.com/novoda/merlin/releases/tag/v1.2.0
Merlin
Problem
Local builds are passing when PRs opened are being failed by the CI, this is because we set a local threshold for local builds but not for PRs. When reducing the number of warnings / errors in the project we should change this threshold accordingly.
Solution
Change the threshold for local builds now that there aren't any errors in the build. Use the latest version of
Merlin
to prevent a failure. https://github.com/novoda/merlin/releases/tag/v1.2.0