Deleted notifications are not dismissed

novoda / download-manager

A library that handles long-running downloads, handling the network interactions and retrying downloads automatically after failures

Apache License 2.0

483 stars 63 forks source link

Deleted notifications are not dismissed #497

Closed Mecharyry closed 4 years ago

Mecharyry commented 5 years ago

Problem

I noticed when testing on Pixel2 that when starting a download and then triggering a delete that the notification is persisted 😬

Solution

Ideally these deleted notifications should be removed from the system notifications. Probably there is a bug in the notification dispatcher.

elee20 commented 5 years ago

Had same issue. Seems that LiteDownloadManagerDownloader.java has a bug. Because "DELETE ALL" button deletes downloadBatch, below notification is never updated.

if (downloadBatch != null) { notificationDispatcher.updateNotification(downloadBatch.status()); }

ouchadam commented 4 years ago

looks like this was fixed by https://github.com/novoda/download-manager/pull/508