search

novoda / download-manager

A library that handles long-running downloads, handling the network interactions and retrying downloads automatically after failures
Apache License 2.0
483 stars 63 forks source link

NOS-519/Migrate to androidx #520

Closed ouchadam closed 4 years ago

ouchadam commented 4 years ago

Replaces the support library imports with androidx

ouchadam commented 4 years ago

this work enables #521

https://github.com/ouchadam/download-manager/compare/NOS-519-migrate-to-androidx...ouchadam:NOS-521-workmanager?expand=1

hal9002 commented 4 years ago

Can one of the admins review this PR?

ouchadam commented 4 years ago

hmmmm 🤔 any CI reports I'm able to view?

Mecharyry commented 4 years ago

Sorry @ouchadam for some reason you can't see them on here when the PR is closed. I've changed the config so that it won't close PRs when they fail now.

ouchadam commented 4 years ago

Looks like there's some pmd errors, will fix

On Wed, 2 Oct 2019, 08:43 Ryan Feline, notifications@github.com wrote:

Reopened #520 https://github.com/novoda/download-manager/pull/520.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/novoda/download-manager/pull/520?email_source=notifications&email_token=AAODHLSWIEQLXTNTQHBBW5TQMRGIJA5CNFSM4I4ACH3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT63ZDYQ#event-2679607778, or mute the thread https://github.com/notifications/unsubscribe-auth/AAODHLQHFRO6MM2TMHBGMPDQMRGIJANCNFSM4I4ACH3A .

ouchadam commented 4 years ago

this PR failed because there's a newer version okHttp 🤦‍♂