search

novoda / gradle-build-properties-plugin

Keep your secrets secret. External build properties support for your Gradle scripts.
Other
110 stars 13 forks source link

Test project properties support #26

Closed mr-archano closed 7 years ago

mr-archano commented 7 years ago

Relates to #20

Scope of the PR

We want to ensure that tests capture the possibility of defining build properties from project properties (including properties provided via the command line as -Pkey=value).

Considerations/Implementation Details

The sample project (and its integration test) have been updated to document the possibility of override a property via command line. Also BuildPropertiesTest is now collecting examples of possible inputs for the BuildProperties.from() utility (Map<String, ?>, System.getenv() and project.properties).

mr-archano commented 7 years ago

are the assertKeysAreThere tests redundant since you're testing the values using the keys?

Good point. I thought I just wanted to ensure the enumeration of keys would still work, but technically the other tests are already catching any misbehaviour 👍