Clarify "using" syntax - Githubissues

ataulm commented 6 years ago

The docs specify how you can reference properties files:

but it says file is deprecated:

where clicking through seems to link to the wrong method?

buildProperties {
    using letterboxd.properties
}

says could not find method using()

How can I get rid of the deprecation warning?

rock3r commented 6 years ago

I think it's a Gradle/Groovy bug where it thinks it's its own file() method, which is deprecated, instead of the Project.file() method you're actually calling. I think this is something @mr-archano is already aware of, seem to recall some discussions of it on Slack last week.

mr-archano commented 6 years ago

@ataulm unfortunately this is a silly issue with the IDE and Groovy, as - in my understanding - file() is resolved using the context of the plugin extension instead of the correct Project.file() (as @rock3r already pointed out). In hindsight, adding that @Deprecated was more harmful than useful, we should get rid of it as this issue has been raised few times already.

ataulm commented 6 years ago

:+1: ugh that's not :sunglasses: grooovy.

shall we transform this issue into that? or will it be time just to remove that method soon?

mr-archano commented 6 years ago

well, we can roll out a patch removing the annotation, you should get the big warning log in the console anyway, it's hard to miss 😅 tiny PR? 😉

ataulm commented 6 years ago

Yep I'll do it tonight, dibs

On Mon, 16 Apr 2018, 09:53 Antonio Bertucci, notifications@github.com wrote:

well, we can roll out a patch removing the annotation, you should get the big warning log in the console anyway, it's hard to miss 😅 tiny PR? 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/novoda/gradle-build-properties-plugin/issues/58#issuecomment-381527566, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjfGwLrrda9EixYDCuFOd27MNNZbs-Aks5tpFwQgaJpZM4TUlFX .

-- Disclaimer: The information in this e-mail and any attachments is the property of Novoda Ltd and is confidential and may be legally privileged. This e-mail is intended solely for the person or organisation to which it is addressed. Any disclosure, copying or other use of the information by any person or organisation who is not the intended recipient is strictly prohibited and may be unlawful. If you have received this e-mail in error, please inform the sender immediately and delete/destroy this e-mail and any copies of it. Novoda Ltd has taken reasonable precautions to minimise the risk of any software viruses which may damage your systems, but we advise that you take the necessary steps to ensure that no virus contamination is suffered. Novoda Ltd does not accept any liability for any loss or damage caused by the transmission of any virus.

Novoda Ltd, Company No: 347444, Registered in Scotland Registered Office: C/O Alexander Sloan, 38 Cadogan Street, Glasgow, G2 7HF, Scotland. VAT Registration Number GB 984 2525 93

novoda / gradle-build-properties-plugin

Clarify "using" syntax #58