tasomaniac
commented
5 years ago As mentioned in the original issue, the reporting behavior may change. We used to provide all reports at once at the end when everything is finished. Would be good if you can provide before/after screenshots of outputs.
On the side, my personal opinion is that this does not add much value.
- These tasks run in parallel.
- except for lint, all tasks are highly cacheable.
High level of parallelization is already provided by Gradle. I am not sure if this improves it.
The way to make check faster (particularly on CI) is to keep modules smaller. When Gradle modules are small, the mentioned overhead is matter of seconds.
lgvalle
Problem
The Static Analysis Plugin serves two main purposes:
evaluateViolations) to execute all those analyses in one go.The problem is that some projects may be interested in those static analysis tasks separately per tool. For example, to parallelise them in CI pipelines or to defer the execution of the most expensive ones to later build stages.
This was raised here too https://github.com/novoda/gradle-static-analysis-plugin/issues/164
Solution
This is my naive approach to the problem. It creates separate tasks per analysis tool:
and makes the original
evaluateViolationstask depends on all of them.The solution Works For Me but it's incomplete existing tests pass, but there are no new ones If this feature is considered interesting for the project I'm happy to pair to make it better.
Generated tasks
These are the tasks generated for the
sampleproject inside this repo before and after the change. Notice the newevaluate<TOOL>Violationtasks. (Sorry for the hacks to align code blocks side by side on markdown :P)Now we can execute individual
evaluate<TOOL>Violationstasks separately or the mainevaluateViolationswhich triggers all the others.Sample: evaluateCheckstyleViolations
If we choose to execute only an individual task, it runs only its tool analysis and produces only results for itself:
EvaluateViolations
For existing users changes in this PR are transparent. They'll see individual tasks reporting messages, but the main one will remain exactly the same. Executing
evaluateViolationswith the same project will produce: