novoda / merlin

Observes network connection status & gives callbacks
Other
543 stars 79 forks source link

MER-157/Runtime crash on clearing registerables #158

Closed Mecharyry closed 6 years ago

Mecharyry commented 6 years ago

Problem

Fix for the crash reported in #157. Registerables are always attempted to be cleared even when a client has not registered for that particular brand of registerable 😬

Solution

Highlight Nullable fields with an annotation and perform a null check before attempting to clear registerables.

Test(s) added

Fixed using TDD.

Paired with

Nobody.