search

novoda / merlin

Observes network connection status & gives callbacks
Other
543 stars 79 forks source link

Removing Jetifier config #200

Closed ouchadam closed 2 years ago

ouchadam commented 4 years ago

Problem

Including this library forces clients to transitively rely on the Jetifier process, which isn't needed since there's no legacy support libraries!

Solution

To remove the jetifier/androidX properties

Test(s) added

N/A since it's build related

ouchadam commented 4 years ago

running https://github.com/plnice/can-i-drop-jetifier on the download manager flags up merlin although since there's no runtime dependencies on the support libraries, so I can only assume this metadata is included in the .aar

running the can-i-drop-jetifier plugin on this repository flags no issues

ouchadam commented 4 years ago

ahhhh @tasomaniac it's because release and develop are out of sync https://github.com/novoda/merlin/blob/release/dependencies.gradle#L16

release still uses the support annotations, will close

actualllyyy leaving open as this forces the library to only use androidx artifiacts