search

novoda / simple-easy-xml-parser

Simple XML Parsing into Domain Objects
Other
69 stars 32 forks source link

adding requireResult and getResult to allow for missing xml fields #10

Closed ouchadam closed 11 years ago

ouchadam commented 11 years ago

9

blundell commented 11 years ago

I can see what your going for and how it reflects the underlying parser.

But without reading the docs I don't think requireResult is immediately obvious.

What about what Cursor does I think that is cool.

getResult & getResultOrThrow

?

blundell commented 11 years ago

I never liked the validation check, but having the two methods makes it more likeable :+1: because you can avoid it when you want. This will also make the user more aware when they do getResult the auto-complete will show getResultOrThrow and remind them of potential null pointers

blundell commented 11 years ago

crazy sick!

lolz

ouchadam commented 11 years ago

awhh yeah back to master!