Fix errors in LastFM module due to change to python3

novoid / Memacs

What did I do on February 14th 2007? Visualize your (digital) life in Org-mode

GNU General Public License v3.0

1.03k stars 66 forks source link

Fix errors in LastFM module due to change to python3 #69

Closed DerBeutlin closed 6 years ago

DerBeutlin commented 6 years ago

fixes #68

removed decode/encode call
updated pylast call to newer version

Things to think about:

There are no tests for this module since it requires an api call. Not sure if it's worth it mocking the api to test the module but this error only wasn't catched by the unittests because there weren't any tests for it.
Many modules depend on other python modules (often specific versions), do we want to put all of them in the requirements.txt allthough not everybody is using every module?

novoid commented 6 years ago

Thanks for fixing! I'm afraid I don't have that much coding experience to decide on your very good questions. I, too, am worried on adding all requirements for all modules. When somebody is only interested in one (simple) Memacs module, why should she/he install a lot of dependencies. Maybe we did a conceptual mistake in the early stage when we decided to use one single repository for all different Memacs modules. I'll open an issue for this just as a reference and as for (future) discussion.