Shouldn't ExtrasUseWindowsDesktopApp only be enabled for netcoreapp?

novotnyllc / MSBuildSdkExtras

Extra properties for MSBuild SDK projects

MIT License

347 stars 42 forks source link

Shouldn't ExtrasUseWindowsDesktopApp only be enabled for netcoreapp? #134

Closed GeertvanHorrik closed 5 years ago

GeertvanHorrik commented 5 years ago

https://github.com/onovotny/MSBuildSdkExtras/blob/e5a8b39d1572a12329ccfaaa3e5f225e5b0523af/Source/MSBuild.Sdk.Extras/Build/ExtrasShim.targets#L29

Currently testing out the latest bits. Shouldn't this only be enabled if the targetframework is a netcoreapp (so don't include in case of net46, etc)?

clairernovotny commented 5 years ago

No since the Desktop SDK includes both netcoreapp3.0 and net targets.