Wrong inference for net5.0 TFM

novotnyllc / MSBuildSdkExtras

Extra properties for MSBuild SDK projects

MIT License

347 stars 43 forks source link

Wrong inference for net5.0 TFM #232

Closed azchohfi closed 4 years ago

azchohfi commented 4 years ago

Shouldn't this consider net5.0? https://github.com/novotnyllc/MSBuildSdkExtras/blob/792a30d95565c65ec9e790ead13e3c2494507094/Source/MSBuild.Sdk.Extras/Build/Inference.targets#L53-L55

clairernovotny commented 4 years ago

Fair point, can you please open an issue to track?

azchohfi commented 4 years ago

I'm sorry Claire, where do you want me to do that? I thought here was the right place. I could also rename this issue and add more info.

clairernovotny commented 4 years ago

Sorry, you're right, don't mind me, it's been a long day :)

chucker commented 4 years ago

I wonder if this (well, the opposite of this?) is why, after I installed .NET 5.0 preview 7, ExtrasEnableWpfProjectSetup no longer seemed to work right on a project that's .NET Framework 4.7.2?