novotnyllc / MSBuildSdkExtras

Extra properties for MSBuild SDK projects
MIT License
345 stars 43 forks source link

.NET Framework packages now take dependency on Microsoft.NETFramework.ReferenceAssemblies #254

Closed dotMorten closed 3 years ago

dotMorten commented 3 years ago

NuGet packages generated with 3.0.22 will cause .NET Framework targets to take a dependency on Microsoft.NETFramework.ReferenceAssemblies in the nuspec.

It seems to me ExtrasImplicitPlatformPackageIsPrivate was meant to default to true and not false.

See discussion: https://github.com/novotnyllc/MSBuildSdkExtras/commit/77e3f3b9b2484b250ff734244732a699f1351411#commitcomment-45713712

Workaround:

 <PropertyGroup Condition="'$(TargetFramework)'=='net461'">
    <ExtrasImplicitPlatformPackageIsPrivate>true</ExtrasImplicitPlatformPackageIsPrivate> 
 </PropertyGroup>
clairernovotny commented 3 years ago

Fixed in 3.0.23

dotMorten commented 3 years ago

You rock! ❤️