novotnyllc / bc-csharp

Portable version of Bouncy Castle with support for .NET 4, .NET Standard 2.0, MonoAndroid, Xamarin.iOS, .NET Core
https://www.bouncycastle.org/csharp
Other
176 stars 36 forks source link

System.NullReferenceException: at Org.BouncyCastle.Asn1.DerOctetString..ctor #81

Closed ghost closed 2 years ago

ghost commented 2 years ago

https://github.com/novotnyllc/bc-csharp/blob/60196c784a98efb64c8a04b7e0385973fd57bc2a/crypto/src/cms/KeyTransRecipientInfoGenerator.cs#L38-L42

subjectKeyIdentifier is always null in this ctor. This seems to be a typo from https://github.com/novotnyllc/bc-csharp/commit/01238566c1d4b2a606e4859a75ad05ca79db4ffb

clairernovotny commented 2 years ago

Hi,

Thanks for finding a bug -- this fork can only accept PRs that are specific to building the netstandard version. Please submit the bug/PR to the upstream repo to ensure it gets fixed for everyone:

https://github.com/bcgit/bc-csharp