Updated EpicSpawnersHook

[SirBlobman]

• Changed to API version 5.2
• Fixed minor compilation issues due to bukkit version names

[Phoenix616]

Can you please add the repository for the EpicSpawners-API artifact to the pom of the epicspawners module? Otherwise the project will not build as that artifact isn't found in maven central or the spigot repo.

Also if it isn't required anymore you can also just remove the epicspawnersapi module.

[SirBlobman]

@Phoenix616 Will do 👍

[SirBlobman]

Apparently EpicSpawners doesn't have a public repo with EpicSpawners-API so I'll just update the module with the proper classes

[Phoenix616]

Please don't include the full code of the API, just the classes and methods that are required to make it work and make them throw UnsupportedOperationExceptions like before. That makes it easier to organise this and avoids potential licensing issues with included code.

Also it might be worth adding the original API version that the module is based on to the artifact version, that way we have that information easily accessible in the future.

[SirBlobman]

Should be done now 👍

[novucs]

I've just tested this with the latest EpicSpawners, it seems SpawnerChangeEvent is never called by EpicSpawners.

[SirBlobman]

I tried to keep it as close to the original as possible, and I don't know the alternative so I'll just let you do the rest. Someone just requested an update and I figured I would submit a PR to the original.

[novucs]

Ah no worries! It's just me being overly picky to keep our codebase small. You've done a good job, thanks for your help. :+1:

[SirBlobman]

No problem 😺

[MedicOP]

SpawnerChangeEvent does not seem to be called when breaking a spawner. Not sure if EpicSpawners made it like that intentionally

[MedicOP]

Check my pull request for working version https://github.com/novucs/factions-top/pull/104