search

novucs / factions-top

An efficient and comprehensive factions ranking system
MIT License
12 stars 26 forks source link

Support FactionsUUID 0.5.0 with backwards compat #116

Closed CmdrKittens closed 4 years ago

CmdrKittens commented 5 years ago

Resolves #115

Untested because compilation requires having old copies of CraftBukkit lying around.

CmdrKittens commented 4 years ago

For FactionsUUID users, this link will (until novucs gets the chance to update things) have a download for a fork of this plugin that only supports FactionsUUID on the latest version (0.5.0+) https://github.com/CmdrKittens/factions-top/releases

This way, people can use a working fork while we wait. Will clear it out once you get the chance to update here :)

Phoenix616 commented 4 years ago

Pretty sure compatibility with the latest factions was implemented in cb4f35ea0c3aa9606ba5d97f6f6900f97da5ba7f, could you check that?

Also I don't think we should maintain backwards compatibility with plugin versions that can easily be updated to newer versions of that plugin without hurting the server compatibility so I don't think we have to spend additional time on adding that compatibility, feel free to comment on that/change the PR to only include that compatibility if you really think it is necessary atm. (Not really sure how the FactionsUUID situation is nowadays)

CmdrKittens commented 4 years ago

Works for me!