search

novucs / factions-top

An efficient and comprehensive factions ranking system
MIT License
12 stars 26 forks source link

Update to newer versions #131

Open AfkF24 opened 4 years ago

AfkF24 commented 4 years ago

Hi,

Any plans of getting Factions Top updated to support 1.15.2? Building the plugin seems to be broken too.

SlickJava commented 4 years ago

Yes please. I've been searching for a working block-calc factions top for 1.15.2 (compatible with FactionsUUID) for a while now... no luck at all.

Phoenix616 commented 4 years ago

Unfortunately updating past 1.13 is a pretty large undertaking as lots of block/item material names changed and a certain amount of work as well as testing has to be put into if the goal should be to keep the update compatible with 1.8 (which lots of factions server still seem to use adamantly).

If the goal was to just get it running on 1.13+ then it shouldn't be too hard but I doubt anyone wants to maintain two separate branches but if anyone thinks it would be a better solution than not having any at all then of course they can create a PR for a quick and dirty fix for 1.13+.

Also ideally you would provide some more information regarding what actually breaks when using in a version past 1.13 as well as for the building. (Which seems to work just fine for me)