search

novucs / factions-top

An efficient and comprehensive factions ranking system
MIT License
12 stars 26 forks source link

When player does /ftop - error happens; when console does /ftop - works #149

Open TheJoshue opened 2 years ago

TheJoshue commented 2 years ago

Title says it all

Just to say i am using latest SaberFactions version. And just to say, this is on latest dev build of FactionsTop image

The weirdest thing is that the FactionsTop plugin from bukkit dev site works extremely fine and everything works ingame using latest SaberFactions plugin.

Console /ftop image

Player ingame /ftop image

Full error

[12:23:27 INFO]: TheJoshua issued server command: /ftop
[12:23:27 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'ftop' in plugin FactionsTop v1.2.1-SNAPSHOT (build 22)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[flamepaper-1.8.8.jar:]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:146) ~[flamepaper-1.8.8.jar:]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.dispatchCommand(CraftServer.java:666) ~[flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.PlayerConnection.handleCommand(PlayerConnection.java:1189) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1001) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java:45) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java:1) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [flamepaper-1.8.8.jar:]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_292]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_292]
        at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:762) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:701) [flamepaper-1.8.8.jar:]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:604) [flamepaper-1.8.8.jar:]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_292]
Caused by: java.lang.NoSuchMethodError: com.massivecraft.factions.Faction.getRelationTo(Lcom/massivecraft/factions/iface/RelationParticipator;)Lcom/massivecraft/factions/perms/Relation;
        at net.novucs.ftop.hook.Factions0106.getRelation(Factions0106.java:92) ~[?:?]
        at net.novucs.ftop.util.StringUtils.getRelationColor(StringUtils.java:37) ~[?:?]
        at net.novucs.ftop.command.TextCommand.sendTop(TextCommand.java:98) ~[?:?]
        at net.novucs.ftop.command.TextCommand.onCommand(TextCommand.java:47) ~[?:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[flamepaper-1.8.8.jar:]
        ... 15 more
Phoenix616 commented 2 years ago

They should really use a different plugin name if they don't care about staying compatible with the upstream's API, this is getting ridiculous. Unfortunately it's pretty much impossible to fix this besides writing a completely separate hook for this plugin as SaberFactions uses a different package for the returned Relation of the getRelationTo method.

I suggest using the old version that works for now.

TheJoshue commented 2 years ago

They should really use a different plugin name if they don't care about staying compatible with the upstream's API, this is getting ridiculous. Unfortunately it's pretty much impossible to fix this besides writing a completely separate hook for this plugin as SaberFactions uses a different package for the returned Relation of the getRelationTo method.

I suggest using the old version that works for now.

build 13 from jenkins works with this i wanted to ask will you ever update PAPI to 2.10.7+ hook because there are big difference? and would you update the latest build 22 PAPi hook + build 13's PAPI hook and release it as "SaberFactions compatible" or at least send me in private (i can send you my discord)

I mean why i am asking for build#13, because it works with SaberFactions, and the PAPI hook that you'll update to bump to papi's 2.10.7+ version, you can literally copy-paste and implement to build13.

TheJoshue commented 2 years ago

I also wanted to ask will you compile this with java8 + java11 too (2 jars)

Phoenix616 commented 2 years ago

I also wanted to ask will you compile this with java8 + java11 too (2 jars)

This doesn't really have anything to do with this issue but the plugin is compiled for Java 8 which works on any version above it. (Realistically you should be running latest or at least latest LTS though (Java 17))

8bitheartbreak commented 1 month ago

What factions plugin are you using? Looks like the factions hook is messing up either due to an outdated or unsupported factions plugin.