search

novucs / factions-top

An efficient and comprehensive factions ranking system
MIT License
12 stars 26 forks source link

MergedSpawner support #60

Open StefvanderMeer opened 7 years ago

StefvanderMeer commented 7 years ago

Hey,

I use mergedspawner and it doesnt show the valid amount of spawners in the faction top.

novucs commented 6 years ago

Their API documentation is quite lacking, plus I'll need to have a jar to test with. I will not be adding support for this unless the developer provides multiplier change events and supplies me with a release. An API along these lines would be optimal: https://github.com/novucs/factions-top/blob/master/hook/manager/src/main/java/net/novucs/ftop/hook/SpawnerStackerHook.java https://github.com/novucs/factions-top/blob/master/hook/manager/src/main/java/net/novucs/ftop/hook/event/SpawnerMultiplierChangeEvent.java

UnrealisticBeing commented 6 years ago

[3:55 PM] vk2gpz: he could just call publicly available API (MergedSpawner.getCountFor(Block spawner);) to find out how many are stacked. [3:55 PM] vk2gpz: it's all mentioned on the overview page.

novucs commented 6 years ago

Again, that's not what I specified for the API I require. If you're desperate to get this added quickly, don't go through me, make an event driven PR. I'm currently incredibly busy. Thank you for understanding.