novuhq / go-novu

GO SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
58 stars 44 forks source link

Missing methods #33

Open sumitsaurabh927 opened 1 year ago

sumitsaurabh927 commented 1 year ago

Some endpoints of the following section can't be hit from this SDK. Please ensure that all the SDK methods are up to date. I'm adding here a list of sections to check/update:

Some of these methods already exist. No need to change/update them. This is just to bring every SDK we have on par with all the methods available.

Check all the endpoints here and add the missing ones.

Cliftonz commented 1 year ago

@sumitsaurabh927 Can you do the same for this one? Thank you!

sumitsaurabh927 commented 1 year ago

Sure, I'll update this issue on every relevant SDK

king-11 commented 1 year ago

Hi @Cliftonz @sumitsaurabh927 can I take this up?

sumitsaurabh927 commented 1 year ago

Hi @Cliftonz @sumitsaurabh927 can I take this up?

Sure @king-11 assigning this to you

sumitsaurabh927 commented 1 year ago

And @king-11 let me know if you're facing any problems!

king-11 commented 1 year ago

Thanks will do 😄

king-11 commented 1 year ago

I took a look at integrations in Swagger a lot of the end points are missing so I need to add them as new functions in the interface and do the same procedure for other listed endpoints.

king-11 commented 1 year ago

Tracking endpoints that are either complete or PR has been made for them

king-11 commented 1 year ago

@sumitsaurabh927 I have raised a PR requesting your review. Please let me know if you would want all the missing methods in one PR or I can go endpoint by endpoint.

sumitsaurabh927 commented 1 year ago

One PR would be fine!

king-11 commented 1 year ago

sure would need sometime for the same

king-11 commented 1 year ago

I am thinking to constrain the PR to just topic and integration because there are just too many new additions for subscriber endpoint will be sending another PR for all the missing options there, we can probably keep the issue open?

Edit: updated previous comment with all the missing methods for subscriber