search

novuhq / go-novu

GO SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
57 stars 45 forks source link

[NV-GO-1] API 🚀: Validate MX Record Setup for Inbound Parse Functionality #8

Open unicodeveloper opened 1 year ago

unicodeveloper commented 1 year ago

🔖 Feature description

There should be a service that validates MX Record Setup for Inbound Parse Functionality

🎤 API Reference https://docs.novu.co/api/validate-the-mx-record-setup-for-the-inbound-parse-functionality/

codeliter commented 1 year ago

Hey @unicodeveloper ,

I just want to say, great job, everyone!!

I would like to contribute, but I have a question.

The NewAPIClient constructor piqued my curiosity. I noticed that when a new client is initialized all services available are injected into the client: https://github.com/novuhq/go-novu/blob/9fc2a94ef1779276cd09dc7347b14567b92ca86a/lib/novu.go#L53-L56

I would appreciate it if I can get more context as to why this pattern was chosen. A doc or a reply here will be nice.

NonsoAmadi10 commented 1 year ago

Hi @unicodeveloper I would like to pick this issue. For context, I noticed every api reference on the documentation have their own file and folder, for the inbound parse functionality, I am thinking i need to create that file as well and write the test, is this correct or there is a file already for this?

NonsoAmadi10 commented 11 months ago

We can close this issue then @unicodeveloper ?