novuhq / hacksquad-website

Contribute code, meet community members, participate in workshops, and win more SWAG 🚀
https://hacksquad.dev
MIT License
261 stars 191 forks source link

Added field for showing rank in the 'My Squad' page #69

Closed PratyayDhond closed 1 year ago

PratyayDhond commented 2 years ago

I couldn't figure it out how to open mySquad page on localhost, and there's no rank variable here in the database of the teams, but I would suggest to pass the (index + 1) of the current team to the my squad component and pass that value as a parameter for rank variable

Closes #56 - partially completed

vercel[bot] commented 2 years ago

@PratyayDhond is attempting to deploy a commit to the Novu Team on Vercel.

A member of the Team first needs to authorize it.

PratyayDhond commented 2 years ago

@nevo-david please check this out

nevo-david commented 2 years ago

But we don't have "rank" in the DB.

PratyayDhond commented 2 years ago

yuppp, @nevo-david, that's why I suggested to pass the index at which the team is as a prop and show that in place of rank, I am not able to configure the github signin that's why I suggested that

vimode commented 2 years ago

Is this still being worked on? Can I try to add this feature?

@PratyayDhond I think you are on the right track, of using the data (teams) from api/leaderboard.js and use the index to display the current rank.

But that can be done with fetching it along with /api/teams in the myteam.jsx, pass the index as prop along with info