search

novuhq / novu-dotnet

.NET SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 13 forks source link

Feature: NotificationTemplateClient #22

Closed wh1337 closed 1 year ago

wh1337 commented 1 year ago

Implement all endpoint methods for the Notification Template endpoints.

Documentation for the endpoints can be found here: https://docs.novu.co/api/get-notification-templates/

Endpoints

unicodeveloper commented 1 year ago

@Badabum are you open to taking up this issue? We'll like to get it in this week.

Badabum commented 1 year ago

Hey, not sure yet. But prob will have some time tomorrow and Thursday to work on it.

Badabum commented 1 year ago

PR for basic operations is here

wh1337 commented 1 year ago

Reviewing

wh1337 commented 1 year ago

Deployed it based off the screenshots of the passing tests, however the tests are failing still resulting in v0.2.1 failing to deploy. Will have to take a look and see what's going on with that @Badabum.

cc: @unicodeveloper

Badabum commented 1 year ago

@wh1337 can you share somehow output of failed tests?

wh1337 commented 1 year ago

@Badabum heres the failed action:

https://github.com/novuhq/novu-dotnet/actions/runs/5085212205/jobs/9138429414#step:7:1

wh1337 commented 1 year ago

Fixed issues and deployed. New version: 0.2.1