novuhq / novu-dotnet

.NET SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 13 forks source link

Replaced `RestSharp` with `Refit` #25

Closed Badabum closed 1 year ago

Badabum commented 1 year ago

This pr replaces RestSharp library with Refit. Refit is a more performant library and utilizes source generation to remove a lot of boilerplate code (as can already be seeing) Related issue: https://github.com/novuhq/novu-dotnet/issues/24

Badabum commented 1 year ago

@wh1337 thx for review! sure will update tests prob tomorrow or on Monday

Badabum commented 1 year ago

@wh1337 I updated tests and code, so all seem good atm

wh1337 commented 1 year ago

Don't worry about the failing action test. It's a known issue for PRs coming in via forks. I have ran the tests locally, and they have all passed:

image

@Badabum for your contribution!