search

novuhq / novu-dotnet

.NET SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 13 forks source link

Targeting .NET 7 may prevent projects using older versions of .NET to use this SDK #26

Closed Badabum closed 1 year ago

Badabum commented 1 year ago

Since the project currently targets .NET 7 (which is non-LTS release btw) people still using .NET 5 / 6 and older won't be able to use this library. Ideally we would want to target at least latest netstandard instead.

wh1337 commented 1 year ago

Good point. Looking here it looks like we have the option to target netstandard-2.0 or netstandard-2.1. Which do you recommend we target? Personally, I would like to target the latest LTS which I believe is netstandard-2.1.

Please correct me if I'm wrong.

Thanks!

Badabum commented 1 year ago

Ideally, it should be netstandard2.0 since it has far better coverage according to this doc

wh1337 commented 1 year ago

We recommend you target .NET Standard 2.0, unless you need to support an earlier version. Most general-purpose libraries should not need APIs outside of .NET Standard 2.0. .NET Standard 2.0 is supported by all modern platforms and is the recommended way to support multiple platforms with one target.

Sounds good. I'll look into targeting netstandard2.0.

Badabum commented 1 year ago

Nice, prob will need to add <LandVersion>latest</LangVersion> so that we still can use latest language features like records, switch expression etc

wh1337 commented 1 year ago

Nice, prob will need to add <LandVersion>latest</LangVersion> so that we still can use latest language features like records, switch expression etc

To your knowledge, would this cause issues with someone using an older lang version?

Badabum commented 1 year ago

Since the nuget package is a compiled and archived version of the lib I don't think there should be issues for consumers of the library.