Closed Badabum closed 1 year ago
@unicodeveloper I fixed your remarks, hope it's more readable now
@unicodeveloper I fixed your remarks, hope it's more readable now
Yes, this is good!
Think we can merge it if no other comments. @wh1337 said before that failing tests are ok for now, bc it's a ci problem
Can you attach a screenshot of passing tests locally whilst we fix the CI issue?
Can you attach a screenshot of passing tests locally whilst we fix the CI issue?
LGTM ⭐
Please update the readme @Badabum
Please update the readme @Badabum
Sure, will do
Just got back into the office and reviewing this will be reviewed and merged tonight @Badabum
Review the comment I put on the review, once resolved we can rebase it on to main.
Thanks @wh1337 please this has to go in today. 🙏🏿
Implemented: