novuhq / novu-dotnet

.NET SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
25 stars 13 forks source link

Added basic operations on notification templates #30

Closed Badabum closed 1 year ago

Badabum commented 1 year ago

Implemented:

Badabum commented 1 year ago

@unicodeveloper I fixed your remarks, hope it's more readable now

unicodeveloper commented 1 year ago

@unicodeveloper I fixed your remarks, hope it's more readable now

Yes, this is good!

Badabum commented 1 year ago

Think we can merge it if no other comments. @wh1337 said before that failing tests are ok for now, bc it's a ci problem

wh1337 commented 1 year ago

Can you attach a screenshot of passing tests locally whilst we fix the CI issue?

Badabum commented 1 year ago

Can you attach a screenshot of passing tests locally whilst we fix the CI issue?

image

unicodeveloper commented 1 year ago

LGTM ⭐

unicodeveloper commented 1 year ago

Please update the readme @Badabum

Badabum commented 1 year ago

Please update the readme @Badabum

Sure, will do

wh1337 commented 1 year ago

Just got back into the office and reviewing this will be reviewed and merged tonight @Badabum

wh1337 commented 1 year ago

Review the comment I put on the review, once resolved we can rebase it on to main.

unicodeveloper commented 1 year ago

Thanks @wh1337 please this has to go in today. 🙏🏿