search

novuhq / novu-dotnet

.NET SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 13 forks source link

Update tests to remove the dependency on a real connection to api.novu.co #34

Closed wh1337 closed 1 year ago

wh1337 commented 1 year ago

Currently, when the test run they require a real connection to the api.novu.co. We need to refactor this to use a mock api so that tests from external PRs can run. This also follows the normal testing process.

RaphaelNagato commented 1 year ago

Hi @wh1337, I will like to pick this up once my PR to add the WorkflowClient is resolved. Thanks

wh1337 commented 1 year ago

@RaphaelNagato I have merged PR #41 (Thank you by the way!) Feel free to start working on this when you can.

Thanks!

RaphaelNagato commented 1 year ago

Hi @wh1337 , I plan to use Wiremock.Net library to resolve this issue, is it okay by you?

wh1337 commented 1 year ago

@RaphaelNagato I'm good with that

toddb commented 1 year ago

Released as part of 0.3.0. However, please note that the additional code to help streamline wiring up the configuration exists in Novu.Extensions.

See #55 for discussion and this code should be release soon.