novuhq / novu-elixir

Elixir SDK for Novu
https://hexdocs.pm/novu
MIT License
27 stars 7 forks source link

Add Exponential Retry Mechanism with Idempotency Headers #25

Closed Cliftonz closed 10 months ago

Cliftonz commented 11 months ago

In order to enhance the resilience and reliability of our SDK, we would like to introduce an Exponential Retry mechanism for retrying failed requests. Additionally, to ensure the idempotent processing of requests, it's vital to incorporate support for providing an Idempotency Key as per the draft specified in the HTTP Idempotency Key Header Field.

The key requirements for this implementation include:

  1. Exponential Retry Mechanism:

    • The SDK should retry failed requests following an exponential backoff strategy to minimize the contention and impact on the systems involved.
    • The SDK should ensure that the retry mechanism is configurable (e.g., max retries, initial delay, maximum delay).
  2. Idempotency Key Provisioning:

    • The SDK should allow for either automatic or manual provisioning of an Idempotency Key for each request.
    • The Idempotency Key should conform to either CUID, ULID, or UUID formats as specified in the draft.
    • The Idempotency Key should be included in the HTTP Header as Idempotency-Key and following the standards outlined in the draft.
  3. Configuration and Documentation:

    • The SDK should provide configuration options for enabling/disabling the Exponential Retry mechanism and Idempotency Key provisioning.
    • Comprehensive documentation should be provided explaining the configuration options, operational behavior, and the benefits of using the Exponential Retry mechanism along with Idempotency Keys.

Acceptance Criteria:

Update: You can reference the go-lang library to keep the method signature and configuration the same. https://github.com/novuhq/go-novu/pull/62

Please refer to the draft for further details on the HTTP Idempotency Key Header Field and ensure adherence to the specified standards while implementing this feature in the SDK.

doomspork commented 11 months ago

Adding a note here for anyone who picks this up: The HTTP library we use, Req, has some retry capabilities built in so worth looking there to start.

Joao-Moura commented 11 months ago

I would like to implement this

unicodeveloper commented 11 months ago

This has been assigned to you @Joao-Moura . Looking forward to your contribution

doomspork commented 10 months ago

This was closed in #31