search

novuhq / novu-elixir

Elixir SDK for Novu
https://hexdocs.pm/novu
MIT License
28 stars 7 forks source link

chore: setup release-please #8

Closed btkostner closed 2 years ago

btkostner commented 2 years ago

This sets up Release Please for the repo. Basically it takes Conventional Commits and generates a changelog, updates documentation versions, and updates the package version. It's very helpful for OSS repos to cut down on maintenance work, and ensure people not 100% familiar with the repo can still release it correctly.

There are a couple of settings that will need to be set on the repo:

1) We need to set the default PR merge method to squash with default to pull request title and description

image

2) We need a personal access token set as GH_PERSONAL_ACCESS_TOKEN secret in the repo. This is used for creating the release in GitHub. Sadly we can't use the normal GITHUB_TOKEN because it won't trigger subsequent actions. You can see a little blurb about this on the release please action README. All it should need is the repo scope. If you want more security, GitHub does have a beta for Fine grained tokens (restricted to only this repo).

image

btkostner commented 2 years ago

@scopsy can we get some assistance on updating the repo settings here please?

scopsy commented 2 years ago

@btkostner Done!

btkostner commented 2 years ago

Error: release-please failed: Personal access tokens with fine grained access do not support the GraphQL API

:facepalm: Apparently GitHub hasn't setup fine grained tokens to work with GraphQL yet. That's uhhh, annoying. @scopsy Any chance you could use a regular personal access token? Sorry about that. I figured it would work because, well, it's still a personal access token. Apparently not.