addressed comments and removed vulnerability

novuhq / novu-java

Java SDK for Novu - The open-source notification infrastructure for engineers. 🚀

MIT License

26 stars 22 forks source link

Closed VishalMCF closed 7 months ago

VishalMCF commented 7 months ago

closes #104

Summary:-

Added loadSdkVersionFromPom() which reads the POM file from the location inside the jar where client has installed the Java-SDK dependency.
Added dependency for MavenXpp3Reader which enables parsing of maven pom files.

VishalMCF commented 7 months ago

@mayorJAY Please review the changes which I made as per your suggestions.

mayorJAY commented 7 months ago

Looks great, just a couple of observations @VishalMCF

VishalMCF commented 7 months ago

@mayorJAY Please review

VishalMCF commented 7 months ago

@Cliftonz Can this be merged now?