search

novuhq / novu-java

Java SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 22 forks source link

Refactor Subscribers API to conform to new design #55

Closed mayorJAY closed 11 months ago

mayorJAY commented 11 months ago

We want to refactor the Subscribers API to address compatibility issues with Micronaut and Quarkus arising from the library's reliance on Spring framework.

We would like to have the Events API migrated to the new REST dependency and ensure the on going updates to the unit tests to validate the modifications and uphold code quality.

For guidance on the expected changes, kindly refer to this pull request #54.

PLEASE BRANCH OFF STAGING BRANCH AND ALL PRS SHOULD GO TO STAGING BRANCH FOR THESE CHANGES

debanjanc01 commented 11 months ago

@mayorJAY could you assign this to me?

mayorJAY commented 11 months ago

Assigned

debanjanc01 commented 11 months ago

hey @mayorJAY , the staging branch seems to have code issues. The Novu.java class seems to have compilation errors because of new FeedsHandler(restHandler, novuConfig); and new MessageHandler(restHandler, novuConfig);. These constructors are missing in the class.

mayorJAY commented 11 months ago

It should be fine now

mayorJAY commented 11 months ago

@debanjanc01 there seems to be no traction on this issue. Are you still working on it?

sccalabr commented 11 months ago

I'll also pick this up if no traction :)

debanjanc01 commented 11 months ago

Hey @mayorJAY , yes I'm working on it. :) Couldn't build the branch because of the compilation failures.

debanjanc01 commented 11 months ago

Hey @mayorJAY , I've raised the PR for the same.