search

novuhq / novu-java

Java SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 22 forks source link

Refactor Integrations API to conform to new design #56

Closed mayorJAY closed 11 months ago

mayorJAY commented 11 months ago

We want to refactor the Integrations API to address compatibility issues with Micronaut and Quarkus arising from the library's reliance on Spring framework.

We would like to have the Events API migrated to the new REST dependency and ensure the on going updates to the unit tests to validate the modifications and uphold code quality.

For guidance on the expected changes, kindly refer to this pull request #54.

PLEASE BRANCH OFF STAGING BRANCH AND ALL PRS SHOULD GO TO STAGING BRANCH FOR THESE CHANGES

charan2628 commented 11 months ago

Hi @mayorJAY , Can I work on this?

mayorJAY commented 11 months ago

Hi @charan2628, I think you've done a very great job so far. You should probably give some other people the opportunity to also contribute. Thank you so much for your contributions

charan2628 commented 11 months ago

Ok @mayorJAY Thank you

sccalabr commented 11 months ago

id like to give this a try

unicodeveloper commented 11 months ago

Assigning this to you @sccalabr

unicodeveloper commented 11 months ago

Assigned to you now @sccalabr

mayorJAY commented 11 months ago

@sccalabr there seems to be no traction on this issue. Are you still working on it?

sccalabr commented 11 months ago

Yes I am working on this

sccalabr commented 11 months ago

@mayorJAY I am trying to figure out how to build and run tests. Once I do I should be able to put up the pr. Do you know how I can do that?

mayorJAY commented 11 months ago

I believe the tests should be in IntegrationsHandlerTest class. You should focus on those tests only. Ensure that they all pass and that's okay