search

novuhq / novu-java

Java SDK for Novu - The open-source notification infrastructure for engineers. 🚀
MIT License
26 stars 22 forks source link

Refactor ExecutiveDetails API to conform to new design #65

Closed mayorJAY closed 11 months ago

mayorJAY commented 11 months ago

We want to refactor the ExecutiveDetails API to address compatibility issues with Micronaut and Quarkus arising from the library's reliance on Spring framework.

We would like to have the Events API migrated to the new REST dependency and ensure the on going updates to the unit tests to validate the modifications and uphold code quality.

For guidance on the expected changes, kindly refer to this pull request #54.

PLEASE BRANCH OFF STAGING BRANCH AND ALL PRS SHOULD GO TO STAGING BRANCH FOR THESE CHANGES

git-ashug commented 11 months ago

Hi @mayorJAY @unicodeveloper , I would like to work on this. Can you assign it to me?

mayorJAY commented 11 months ago

Assigned

git-ashug commented 11 months ago

Hi, for almost every *Handler.java file, I see a 'private static final String ENDPOINT' declared and assigned some value originally in the codebase. But for ExecutiveDetailsHandler.java there is no ENDPOINT variable(context path) declared. Is there a specific reason for this OR should I add this in my change?